Merge pull request #213 from acelaya-forks/feature/remove-swoole

Drop support for openswoole
shlinkio · Feb 16, 2024 · 2dee7db · 2dee7db
2 parents 9f0d7e5 + af7e8be
commit 2dee7db
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com), and this
 ### Removed
 * Remove config options related with webhooks.
 * Remove config option to decode redis credentials.
+* Remove support for openswoole.
 
 ### Fixed
 * *Nothing*

diff --git a/src/Config/Option/Server/RuntimeConfigOption.php b/src/Config/Option/Server/RuntimeConfigOption.php
@@ -15,7 +15,6 @@ class RuntimeConfigOption extends BaseConfigOption
     public const ENV_VAR = 'RUNTIME';
     private const RUNTIMES = [
         'RoadRunner' => RuntimeType::ASYNC,
-        'Openswoole' => RuntimeType::ASYNC,
         'Classic web server (Nginx, Apache, etc)' => RuntimeType::REGULAR,
     ];
 

diff --git a/test/Config/Option/Server/RuntimeConfigOptionTest.php b/test/Config/Option/Server/RuntimeConfigOptionTest.php
@@ -35,7 +35,6 @@ public function expectedQuestionIsAsked(string $answer, RuntimeType $expectedRun
             . 'follow-up questions)',
             [
                 'RoadRunner',
-                'Openswoole',
                 'Classic web server (Nginx, Apache, etc)',
             ],
             'RoadRunner',
@@ -49,7 +48,6 @@ public function expectedQuestionIsAsked(string $answer, RuntimeType $expectedRun
     public static function provideRuntimes(): iterable
     {
         yield 'RoadRunner' => ['RoadRunner', RuntimeType::ASYNC];
-        yield 'Openswoole' => ['Openswoole', RuntimeType::ASYNC];
         yield 'Classic web server' => ['Classic web server (Nginx, Apache, etc)', RuntimeType::REGULAR];
     }
 }
diff --git a/test/Config/Option/Worker/TaskWorkerNumConfigOptionTest.php b/test/Config/Option/Worker/TaskWorkerNumConfigOptionTest.php
@@ -92,7 +92,7 @@ public static function provideInvalidValues(): iterable
     }
 
     #[Test, DataProvider('provideCurrentOptions')]
-    public function shouldBeAskedWhenNotPresentAndSwooleIsInstalled(
+    public function shouldBeAskedWhenNotPresentAndRuntimeIsAsync(
         array $currentOptions,
         bool $expected,
     ): void {