Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: add AIX support #834

Merged
merged 1 commit into from
Mar 1, 2020
Merged

net: add AIX support #834

merged 1 commit into from
Mar 1, 2020

Conversation

Helflym
Copy link
Contributor

@Helflym Helflym commented Feb 10, 2020

No description provided.

@Helflym
Copy link
Contributor Author

Helflym commented Feb 27, 2020

Any news about this CL ? I need it for other go packages.

@Lomanic
Copy link
Collaborator

Lomanic commented Feb 28, 2020

Sorry, I wanted to check it out but it was really hard to come by a way to get AIX on Virtualbox (for free). I finally stumbled upon this promising blog article but didn't get the chance to test it out. With some exceptions I'm only able to work on gopsutil on the weekend, and even then, not all weekends.

Also, I wasn't sure if it would have been a good idea to merge this if nobody in the team would be able to test and fix things for this OS in the future.

@Helflym
Copy link
Contributor Author

Helflym commented Feb 28, 2020

Yes, I understand your point of view. You're not the only Go package maintainers wondering how to check on AIX. Sadly, I don't have any solutions for you (AIX 1.3 won't work at all with Go, trust me !).
The only solution right now is that AIX community has to provide patches when you'll be introducing new features/bugs. As your package is included in wider projects, at least beats software, we're likely to detect bug or missing features will compiling their new versions.

@shirou
Copy link
Owner

shirou commented Mar 1, 2020

Thank you for this PR. And as @Lomanic said, we can not check gopsutil is working on all platforms. So I agree to @Helflym, I trust that platform community. If gopsutil can not work on the platforms, someone will open an issue or PR like this PR. This is a OSS. Therefore, I merge this PR. Thank you for your contribution!

(Sorry for late response. I can work only weekend same as @Lomanic. I am very appreciate and respecting @Lomanic about his contribution)

@shirou shirou merged commit a3b23c5 into shirou:master Mar 1, 2020
@Lomanic Lomanic mentioned this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants