chore: enable use-any from revive #1784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
revive/use-any
branch
from
a643fae to
27ea38b
Compare
|
I don't know much about the Revive, but is it possibly only supported on Linux?. It seems net/net_windows.go and internal/common/common_windows.go have also |
|
I believe, that's probably more golangci-lint related you need to run it with differenr GOOS or GOARCH to cover them all. |
|
I took a look earlier because I was curious and I was about to post when I saw your reply @mmorel-35 You can find an explanation here It's not really about GOARCH and co with golangci-lint, as the tool is already compiled. So adding a golangci-lint job per arch via matrix seems the solution. It's strange I had never faced this. So good catch @shirou TIL something and I'm happy about it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use-any: Since Go 1.18, interface{} has an alias: any. This rule proposes to replace instances of interface{} with any.