Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use build release #188

Closed
wants to merge 4 commits into from
Closed

Conversation

jkhelil
Copy link
Contributor

@jkhelil jkhelil commented Feb 5, 2024

Changes

  • Use release.yaml from build github release
  • Replace manifestival/controller-runtime-client with manifestival/client-go-client

Fixes #184

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

None

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 5, 2024
Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jkhelil. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkhelil
Copy link
Contributor Author

jkhelil commented Feb 8, 2024

@adambkaplan I am tryijng to move from manifestival/controller-runtie-cient to maifestival/client-go-client, hoping it handling the server side apply
hiweer the tests are not working unfortenately on envtest.
Do you have any idea why envtest is not initlialzing with client-go?

@adambkaplan
Copy link
Member

I would imagine that this PR will need more work replacing instances of the controller-runtime client with the plain k8s client, which would have far-reaching consequences.

Per @joelanford - it sounds like we can use the controller-runtime Patch method and send it unstructured JSON, which would then let us do server-side apply. If we take this approach, we'd want to contribute the change to Manifestival.

We may also want to take this as a moment to reconsider the manfiestival-based approach in the operator. Tekton and ArgoCD's operators both share the challenge of deploying their own "child" CRDs - what are they doing?

cc @vdemeester @janfis

@qu1queee
Copy link

From Refinement, nothing to do here, and it might be fixed by another PR.

@qu1queee qu1queee closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] v0.12.0 does not ship an exact match of build v0.12.0
3 participants