[FEATURE] Handle deletion of roles for webhook deployment #181
Assignees
Labels
help wanted
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
kind/feature
Categorizes issue or PR as related to a new feature.
Milestone
Comments
SaschaSchwarze0
added
the
kind/feature
qu1queee
added
the
help wanted
1 task
4 tasks
4 tasks
|
/close Fixed in #214 |
|
@adambkaplan: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing feature request for this?
Is your feature request related to a problem or use-case? Please describe.
We shipped Shipwright Build v0.12.0 with a cluster role and a binding for the webhook that are unnecessary. To follow least-privilege principle, we removed them in shipwright-io/build#1448.
The operator must handle the deletion.
Describe the solution that you would like.
When updating v0.13.0, the operator should delete the clusterrole
shipwright-build-webhookand the clusterrolebindingshipwright-build-webhook.Describe alternatives you have considered.
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: