Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organize imports #452

Merged
merged 1 commit into from
Oct 29, 2020
Merged

organize imports #452

merged 1 commit into from
Oct 29, 2020

Conversation

coreydaley
Copy link
Contributor

Group and order golang imports

Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@coreydaley-redhat did you use any tooling to automate this? Would be nice if we could include it in our make generate/make verify targets.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2020
@adambkaplan
Copy link
Member

Restarted the travis build - looks like it flaked on a build (timed out)

@coreydaley
Copy link
Contributor Author

/lgtm

@coreydaley-redhat did you use any tooling to automate this? Would be nice if we could include it in our make generate/make verify targets.

From a previous hack day: https://github.com/coreydaley-redhat/osgoimports

@coreydaley
Copy link
Contributor Author

Restarted the travis build - looks like it flaked on a build (timed out)

I tried to restart it but did not have access on Travis to restart the test.

@openshift-merge-robot openshift-merge-robot merged commit b6d900f into shipwright-io:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants