Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bind methods to their own file #222

Merged
merged 3 commits into from
Aug 25, 2018
Merged

Conversation

RobbieTheWagner
Copy link
Member

No description provided.

Copy link
Member

@chuckcarpenter chuckcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all LGTM

@@ -77,14 +87,14 @@ export class Step extends Evented {
const text = createFromHTML('<div class="shepherd-text"></div>');
let paragraphs = this.options.text;

if (typeof paragraphs === 'function') {
if (_.isFunction(paragraphs)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much cleaner

@chuckcarpenter
Copy link
Member

@RobbieTheWagner RobbieTheWagner merged commit c9faa02 into master Aug 25, 2018
@RobbieTheWagner RobbieTheWagner deleted the move-bind-methods branch August 25, 2018 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants