This repository has been archived by the owner on Oct 9, 2024. It is now read-only.
feat: add @start to CodeBlock for custom line number start #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascudder
reviewed
Jul 23, 2022
|
@rwwagner90, @ascudder, feedback addressed. Can we merge? |
RobbieTheWagner
approved these changes
Jul 25, 2022
RobbieTheWagner
approved these changes
Jul 25, 2022
|
Can this get published to npm soon so we can use it in our project? Anything I could do to help? |
|
Thank you @rwwagner90 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
@startarg to<CodeBlock />, as per the MR my colleague @Syn-Tylor made, this time with passing tests to back it.