This repository has been archived by the owner on Oct 9, 2024. It is now read-only.
Use require.resolve() to check if Prism plugin files exist
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old approach implied that the filesystem layout of the `node_modules` folder is flat, but this does not necessarily have to be the case. For example, when using pnpm as a package manager the `prism` package will be resolvable from `ember-prism`, but it will not be at the location that the old approach expects. This commit should fix the problem by relying on the node module resolution algorithm to determine if certain files of the Prism package exist or not.
RobbieTheWagner
approved these changes
Mar 8, 2021
|
LGTM! Thanks for the PR. |
|
thanks for merging :) do you have any releases planned within the next days? |
|
Just released 0.9.1 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old approach implied that the filesystem layout of the
node_modulesfolder is flat, but this does not necessarily have to be the case. For example, when using pnpm as a package manager, theprismpackage will be resolvable fromember-prism, but it will not be at the location that the old approach expects. This commit should fix the problem by relying on the node module resolution algorithm to determine if certain files of the Prism package exist or not./cc @rwwagner90