You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SetupUpgrade.php should have version_compare() if statements by module's setup version.
I see SetupSchema has version_compare, but not SetupUpgrade doesn't.
If I have 1.0.9 and I just upgraded to 1.0.10, all instructions are run.
Although addAttribute and other functions from $categorySetup/Factory are fail safe, it's still not proper to run those functions.
The text was updated successfully, but these errors were encountered:
SetupUpgrade.php should have version_compare() if statements by module's setup version.
I see SetupSchema has version_compare, but not SetupUpgrade doesn't.
If I have 1.0.9 and I just upgraded to 1.0.10, all instructions are run.
Although addAttribute and other functions from $categorySetup/Factory are fail safe, it's still not proper to run those functions.
The text was updated successfully, but these errors were encountered: