Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All SetupUpgrade runs every time a new setup version is discovered #23

Closed
daniel-ifrim opened this issue May 10, 2017 · 1 comment
Closed

Comments

@daniel-ifrim
Copy link

SetupUpgrade.php should have version_compare() if statements by module's setup version.
I see SetupSchema has version_compare, but not SetupUpgrade doesn't.

If I have 1.0.9 and I just upgraded to 1.0.10, all instructions are run.
Although addAttribute and other functions from $categorySetup/Factory are fail safe, it's still not proper to run those functions.

@wsagen
Copy link
Contributor

wsagen commented May 25, 2017

Thanks for raising, we've modified the upgrade scripts to include version checks in latest and all future versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants