Drop BetterReflection to speed up analysis

README.md

@@ -1,6 +1,7 @@
 # Name collision detector
 
-Simple tool which allows you to detect if there are no classes/functions/constants defined multiple times within the same namespace.
+Simple tool which allows you to detect if there are no types defined multiple times within the same namespace.
+This means that any ambiguous class, interface, enum, trait, constant or function is reported.
 Non-zero exit code is returned when any duplicate is found.
 
 ## Installation:
@@ -10,26 +11,18 @@ composer require --dev shipmonk/name-collision-detector
 ```
 
 ## Usage:
-Check duplicate classes, constants and functions:
+Check duplicate types:
 ```sh
 vendor/bin/detect-collisions dir1 dir2 dir3
 ```
 
-Or you can select what to check:
-
-```sh
-vendor/bin/detect-collisions --classes src tests # check only duplicate classes
-vendor/bin/detect-collisions --functions src tests # check only duplicate functions
-vendor/bin/detect-collisions --constants src tests # check only duplicate constants
-```
-
 Example output:
 ```
 Foo\NamespacedClass2 is defined 2 times:
  > /tests/sample-collisions/file2.php
  > /tests/sample-collisions/file2.php
 
-GlobalClass1 is defined 2 times:
+GlobalInterface1 is defined 2 times:
  > /tests/sample-collisions/file1.php
  > /tests/sample-collisions/file2.php
 ```
@@ -40,6 +33,6 @@ Typically, you have PSR-4 autoloading solving this problem for you, but there ar
 And in such cases, the test may work when executed in standalone run, but fail when running all the tests together (depending on which class was autoloaded first).
 Therefore, having a collision detector in CI might be useful.
 
-## Versions
-- 1.x supports PHP 7.2 - PHP 8.2
+## Supported PHP versions
+- PHP 7.2 - PHP 8.2
 

bin/detect-collisions

@@ -1,6 +1,7 @@
 #!/usr/bin/env php
 <?php declare(strict_types=1);
 
+use ShipMonk\FileParsingException;
 use ShipMonk\InvalidPathProvidedException;
 use ShipMonk\NameCollisionDetector;
 
@@ -16,16 +17,10 @@ foreach ($autoloadFiles as $autoloadFile) {
     }
 }
 
-$possibleOptions = ['classes', 'functions', 'constants'];
-$providedOptions = getopt('', $possibleOptions, $restIndex);
-$check = array_keys($providedOptions);
-$check = $check === [] ? $possibleOptions : $check; // check all if no option is provided
-
 $cwd = getcwd();
-$providedFolders = array_slice($argv, $restIndex);
-$directories = array_map(static function (string $arg) use ($cwd): string {
+$directories = array_map(static function ($arg) use ($cwd) {
     return $cwd . '/' . $arg;
-}, $providedFolders);
+}, array_slice($argv, 1));
 
 if ($directories === []) {
     echo "ERROR: no directories provided, use e.g. `detect-collisions src tests`\n";
@@ -34,19 +29,13 @@ if ($directories === []) {
 
 try {
     $detector = new NameCollisionDetector($directories, $cwd);
-} catch (InvalidPathProvidedException $e) {
+    $collisions = $detector->getCollidingTypes();
+
+} catch (InvalidPathProvidedException | FileParsingException $e) {
     echo "ERROR: {$e->getMessage()}\n";
     exit(255);
 }
 
-echo "Checking duplicates of " . implode(' and ', $check) . " in " . implode(', ', $providedFolders) . ":\n\n";
-
-$collisions = array_merge(
-    in_array('classes', $check, true) ? $detector->getCollidingClasses() : [],
-    in_array('functions', $check, true) ? $detector->getCollidingFunctions() : [],
-    in_array('constants', $check, true) ? $detector->getCollidingConstants() : []
-);
-
 foreach ($collisions as $name => $filePaths) {
     $count = count($filePaths);
     echo "$name is defined $count times:\n";

composer.json

@@ -1,17 +1,20 @@
 {
     "name": "shipmonk/name-collision-detector",
-    "description": "Simple tool to find class/function/constant name duplicates within your project.",
+    "description": "Simple tool to find ambiguous classes or any other name duplicates within your project.",
     "license": [
         "MIT"
     ],
     "keywords": [
         "namespace",
         "collision",
+        "ambiguous",
         "autoload",
-        "classname"
+        "classname",
+        "autoloading"
     ],
     "require": {
-        "roave/better-reflection": "4.* || 5.* || 6.*"
+        "php": "^7.2 || ^8.0",
+        "ext-tokenizer": "*"
     },
     "require-dev": {
         "editorconfig-checker/editorconfig-checker": "^10.3.0",