Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle case when attribute name passed to has_attribute is not a string #309

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Handle case when attribute name passed to has_attribute is not a string #309

merged 2 commits into from
Nov 30, 2018

Conversation

shioyama
Copy link
Owner

This only matters for ActiveRecord 5.1 with Dirty enabled.

Fixes #308.

@shioyama shioyama mentioned this pull request Nov 30, 2018
Closed
@shioyama
Copy link
Owner Author

This should have closed... anyway merged in 25abd5d

@shioyama shioyama closed this Nov 30, 2018
@shioyama shioyama reopened this Nov 30, 2018
@shioyama shioyama merged commit 6f0e244 into master Nov 30, 2018
@shioyama
Copy link
Owner Author

Ok properly merged this time.

@shioyama shioyama temporarily deployed to github-pages November 30, 2018 04:55 Inactive
@shioyama shioyama deleted the fix_308 branch November 30, 2018 08:35
@shioyama shioyama mentioned this pull request Dec 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shioyama