Handle uniqueness validation for translated attributes and translated scopes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
force-pushed
the
uniqueness_validation
branch
from
285d7a0 to
354701e
Compare
shioyama
force-pushed
the
uniqueness_validation
branch
from
354701e to
2c35c8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
Mobility::ActiveRecord::UniquenessValidatorthat is defined as a subclass on a model namespace when the model includesMobility. By doing this, the model will use this validator ifvalidatesis called withuniqueness: true, but due to the namespacing the validator will not be used for any other (non-translated) models.I'm conciously avoiding monkey-patching the original uniqueness validator since that could have strange and unpredictable results. The validator defined here sticks to very simple queries using
whereandnotin order to be compatible with any supported backend.Fixes #20