Use element operator instead of contains for jsonb querying #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, queries on jsonb columns in the
Jsonb
andContainer
backends are performed using the "contains" operator (@>
). This works fine for string/integer/boolean values, but for hash valued-translations it returns a match even if the hash contains other keys/values (i.e. it does not perform an exact match).Instead of using "contains" (
@>
), we can also use the normal element operator (->
), so for a queryPost.i18n.where(title: { "a" => "b" })
, instead of this:we instead get this:
The first SQL will match a post with a title value
'{"a":"b","c":"d"}'
, but the second will not.Although this is an edge case, I think in general it's also better not to use the jsonb-specific contains operator if it's not really necessary anyway.