Test against ActiveRecord 5.2.0.beta.x #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
force-pushed
the
test_against_ar_5_2
branch
from
d62a791 to
8ebac53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of changes coming up relating to how attributes are treated in ActiveModel and ActiveRecord. I just ran the test suite against the beta version of AR 5.2 and there are 26 failures, mostly relating to AR::Dirty.
In parallel I'm working on supporting some of the new AR::Dirty methods like
saved_changesin #111, in response to #106, but I'm wondering if these changes will just make the transition to 5.2.0 harder. For now I'll continue on #111 but here I'm adding the latest AR versions to the build withallow_failures, so we can see what we will need to do to make this all work.