Do not index text translation columns on value

MySQL doesn't like this index since the text column is huge so hard to index without a limit. Probably better to let the developer add this index themselves. Closes #8.
shioyama · Mar 16, 2017 · 574172d · 574172d
1 parent 19f89b3
commit 574172d
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 3 deletions.
diff --git a/lib/generators/rails/mobility/templates/create_text_translations.rb b/lib/generators/rails/mobility/templates/create_text_translations.rb
@@ -11,6 +11,5 @@ def change
     end
     add_index :mobility_text_translations, [:translatable_id, :translatable_type, :locale, :key], unique: true, name: :index_mobility_text_translations_on_keys
     add_index :mobility_text_translations, [:translatable_id, :translatable_type, :key], name: :index_mobility_text_translations_on_translatable_attribute
-    add_index :mobility_text_translations, [:translatable_type, :key, :value, :locale], name: :index_mobility_text_translations_on_query_keys
   end
 end
diff --git a/spec/active_record/schema.rb b/spec/active_record/schema.rb
@@ -65,7 +65,6 @@ def up
           end
           add_index :mobility_text_translations, [:translatable_id, :translatable_type, :locale, :key], unique: true, name: :index_mobility_text_translations_on_keys
           add_index :mobility_text_translations, [:translatable_id, :translatable_type, :key], name: :index_mobility_text_translations_on_translatable_attribute
-          add_index :mobility_text_translations, [:translatable_type, :key, :value, :locale], name: :index_mobility_text_translations_on_query_keys
 
           create_table "comments" do |t|
             t.text :content_en

diff --git a/spec/sequel/schema.rb b/spec/sequel/schema.rb
@@ -64,7 +64,6 @@ def migrate(*)
             String      :translatable_type, null: false
             index [:translatable_id, :translatable_type, :locale, :key], unique: true, name: :index_mobility_text_translations_on_keys
             index [:translatable_id, :translatable_type, :key], name: :index_mobility_text_translations_on_translatable_attribute
-            index [:translatable_type, :key, :value, :locale], name: :index_mobility_text_translations_on_query_keys
           end
 
           DB.create_table? :mobility_string_translations do