allow translated and non-translated slugs with history in the same project #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… translated slugs
|
Thanks very much for this! I honestly don't use friendly_id so hard to evaluate this. Will this be a breaking change? |
khalilgharbaoui
added a commit
to khalilgharbaoui/friendly_id-mobility
that referenced
this pull request
Feb 17, 2024
I'm not 100% sure. It opens up a new scenario while leaving the present ones untouched. One thing should be checked though and that is how it behaves in conjunction with the global settings one can set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #27 by loosen the
localeconstraint and taking the :mobility plugin usage into account for eachsluggable.