Skip to content

Commit

Permalink
OCPBUGS-631: Pull container image as a separate step
Browse files Browse the repository at this point in the history
In order to avoid a podman issue [1] causing a layer corruption when an
image pull is killed midway, let's move the image pull outside of the
timeout command.

The timeout was recently reduced to 20 seconds with [2] making the issue
more likely to happen.

[1] containers/podman#14003
[2] openshift#3271
  • Loading branch information
mandre committed Aug 31, 2022
1 parent b2a719d commit 0cd7f83
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ contents:
cp /var/run/NetworkManager/resolv.conf /etc/resolv.conf
fi
# Pull container image outside of the timeout to workaround possible
# image corruption
# https://github.com/containers/podman/issues/14003
/usr/bin/podman pull --authfile /var/lib/kubelet/config.json {{ .Images.baremetalRuntimeCfgImage }}
NAMESERVER_IP=$(timeout 20s /usr/bin/podman run --rm \
--authfile /var/lib/kubelet/config.json \
Expand Down

0 comments on commit 0cd7f83

Please sign in to comment.