Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply changes for 3.2.7 release #911

Merged
merged 80 commits into from
Jul 29, 2023
Merged

Conversation

shiftkey
Copy link
Owner

@shiftkey shiftkey commented Jul 27, 2023

  • CI passes
  • diff makes sense
  • can generate installer and test locally
  • can download installer artifact and install locally

shiftkey and others added 30 commits July 27, 2023 08:46
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
Reduce errors produced in terminal from debian package installations by testing for existence of symlink prior to executing unlink
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey and others added 19 commits July 27, 2023 09:24
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
* Bump electron-installer-redhat from 3.3.0 to 3.4.0

Dependabot couldn't find the original pull request head commit, 6b63cfc.

* regenerate patch file

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brendan Forster <[email protected]>
* Update linux.ts

Fix #885 for VSCode, VSCodium, and VSCode Insiders

* Use full path for Flatpak binaries

Adds full path, as previous method didn't function properly.
* adjust release flow to skip the release- prefix

* aupdate glob to look recursively for artifacts

* fail when the files cannot be found
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 3.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v2...v3)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@theofficialgman
Copy link

let me know if you run into any issues with the ARM support.
Looking forward to the release

@shiftkey
Copy link
Owner Author

@theofficialgman so far it all seems fine, just dealing with other things which is limiting my spare time. Aiming to make this available today at least.

@shiftkey shiftkey marked this pull request as ready for review July 29, 2023 12:27
@shiftkey shiftkey merged commit 08c237c into linux-release-3.2.7 Jul 29, 2023
@shiftkey shiftkey deleted the apply-changes-3.2.7 branch July 29, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.