Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix args processing on first launch on linux #793

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Fix args processing on first launch on linux #793

merged 1 commit into from
Feb 17, 2023

Conversation

sarim
Copy link

@sarim sarim commented Nov 12, 2022

Closes #620

Description

On linux, on first launch of github desktop, it ignores any passed command line arguments. If a instance is already running, and you run the command again, it processes 2nd (and subsequent) launches' command line arguments. This PR adds a call so that it processes args on first launch too. More details at linked issue #620.

Release notes

Notes: Fix github . command not opening or adding current folder as repository on first launch.

@sarim
Copy link
Author

sarim commented Jan 31, 2023

@shiftkey sorry to tag, but can you review this please :)

shiftkey
shiftkey approved these changes Feb 17, 2023
View reviewed changes
Copy link
Owner

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we already had this covered - guess this was undone during cutting a release.

Thanks for the contribution @sarim!

@shiftkey shiftkey merged commit 787ef6c into shiftkey:linux Feb 17, 2023
shiftkey pushed a commit that referenced this pull request Feb 17, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
70e66f5
shiftkey pushed a commit that referenced this pull request Feb 17, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
7f82ca0
shiftkey pushed a commit that referenced this pull request Feb 17, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
474a2bc
shiftkey pushed a commit that referenced this pull request Feb 17, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
2b97670
shiftkey pushed a commit that referenced this pull request Feb 17, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
7b62fc0
shiftkey pushed a commit that referenced this pull request Feb 17, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
974d938
shiftkey pushed a commit that referenced this pull request Feb 26, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
4d51112
shiftkey pushed a commit that referenced this pull request Feb 26, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
4e5e160
shiftkey pushed a commit that referenced this pull request Feb 26, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
c5f119f
shiftkey pushed a commit that referenced this pull request Mar 1, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
f696c60
shiftkey pushed a commit that referenced this pull request Mar 1, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
1c3071f
shiftkey pushed a commit that referenced this pull request Mar 1, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
132543d
shiftkey pushed a commit that referenced this pull request Mar 2, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
8328595
shiftkey pushed a commit that referenced this pull request Mar 15, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
17a7b76
shiftkey pushed a commit that referenced this pull request Apr 4, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
55d48fa
shiftkey pushed a commit that referenced this pull request Apr 7, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
3396fc9
shiftkey pushed a commit that referenced this pull request Apr 7, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
1d8c3e8
shiftkey pushed a commit that referenced this pull request Apr 7, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
152a419
theofficialgman pushed a commit to theofficialgman/desktop that referenced this pull request Jun 4, 2023
@sarim @theofficialgman
Fix args processing on first launch on linux (shiftkey#793)
dba393c
shiftkey pushed a commit that referenced this pull request Jun 5, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
72a567d
shiftkey pushed a commit that referenced this pull request Jun 5, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
df07f85
shiftkey pushed a commit that referenced this pull request Jul 3, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
72e9960
shiftkey pushed a commit that referenced this pull request Jul 3, 2023
@sarim @shiftkey
Fix args processing on first launch on linux (#793)
cbace28
shiftkey pushed a commit that referenced this pull request Aug 14, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
87637e1
shiftkey pushed a commit that referenced this pull request Aug 15, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
20bd7b8
shiftkey pushed a commit that referenced this pull request Aug 17, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
93ea0e3
shiftkey pushed a commit that referenced this pull request Aug 17, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
35ba835
shiftkey pushed a commit that referenced this pull request Sep 2, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
084bcf3
shiftkey pushed a commit that referenced this pull request Sep 2, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
abb072f
shiftkey pushed a commit that referenced this pull request Oct 30, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
9d407f2
shiftkey pushed a commit that referenced this pull request Nov 8, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
346c661
shiftkey pushed a commit that referenced this pull request Nov 8, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
43b9415
shiftkey pushed a commit that referenced this pull request Nov 8, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
a93719c
shiftkey pushed a commit that referenced this pull request Nov 8, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
5ebd818
shiftkey pushed a commit that referenced this pull request Nov 8, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
8b7da70
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
978afab
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
7a173e1
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
e72301b
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
36940e4
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
24f0101
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
a400676
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
573a81f
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
8857650
shiftkey pushed a commit that referenced this pull request Feb 5, 2025
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
5326354
shiftkey pushed a commit that referenced this pull request Feb 5, 2025
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
06f2aeb
shiftkey pushed a commit that referenced this pull request Feb 5, 2025
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
85f8517
shiftkey pushed a commit that referenced this pull request Feb 5, 2025
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
6c193fe
shiftkey pushed a commit that referenced this pull request Feb 5, 2025
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
3b85be1
shiftkey pushed a commit that referenced this pull request Feb 9, 2025
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
9208808
shiftkey pushed a commit that referenced this pull request Feb 9, 2025
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
40955d9
shiftkey pushed a commit that referenced this pull request Feb 9, 2025
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
7bad4e3
shiftkey pushed a commit that referenced this pull request Feb 9, 2025
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
f303e9d
shiftkey pushed a commit that referenced this pull request Feb 9, 2025
@sarim @shiftkey
fix: args processing on first launch on linux (#793)
5f5bcc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftkey shiftkey shiftkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

github . from the command line doesn't add the current folder as a repository on first launch
2 participants
@sarim @shiftkey