Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userns check #261

Closed
wants to merge 1 commit into from
Closed

userns check #261

wants to merge 1 commit into from

Conversation

jfgordon2
Copy link

Closes #222

Description

Check for userns prior to launching github desktop, allow user to choose to run with sandbox disabled

Screenshots

image

Release notes

Notes: Added prelaunch script to allow a check for user namespace and potentially other future checks

Check for userns prior to launching github desktop, allow user to choose to run with sandbox disabled
@shiftkey
Copy link
Owner

This is an interesting idea, but I'd like to better understand how/why Desktop is causing this crash. I was able to confirm yesterday a plain Electron app worked fine with this setting disabled, and was digging into what this setting is actually enforcing on the renderer process (which I believe is being subjected to the sandboxing that relies on this setting) is what I'd like to answer before we go further.

@jfgordon2
Copy link
Author

Ah, of course. Let me know if I can do anything to help.

@shiftkey
Copy link
Owner

Closing this out now that we know the root cause, and should not require the user change their setup or disable the sandboxing: #222 (comment)

@shiftkey shiftkey closed this Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"SUID sandbox helper binary" warning on debian 10
2 participants