Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use device_type to fetch Device Type Name #17

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

aashays
Copy link
Contributor

@aashays aashays commented Nov 16, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #17 (a35474b) into main (70d8902) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files          21       21           
  Lines         948      948           
=======================================
  Hits          939      939           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d8902...a35474b. Read the comment docs.

@Kakise
Copy link
Collaborator

Kakise commented Nov 28, 2021

What does it change exactly and what does it fix ?

@aashays
Copy link
Contributor Author

aashays commented Nov 29, 2021

Easy to see if you expand the diff. model is undefined in the file.

@Kakise Kakise merged commit 45c27b8 into shenxn:main Nov 30, 2021
@Kakise
Copy link
Collaborator

Kakise commented Nov 30, 2021

Easy to see if you expand the diff. model is undefined in the file.

Thanks ! I did not notice this oversight !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants