-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.13 output became too verbose #31
Comments
Haha 🤣, thanks for your comment. It is kind of verbose. It's meant to provide more details.
|
Alas, -q makes the app too quiet. Imagine you are in a car, its windshield is dirty, and you press a button to clean it. At present, the cleaning is accompanied by readings from a dozen sensors — it makes you keep an eye on everything and eventually causes anxiety. Using -q turns this process into wandering in the dark: the lights go out, a pause of unknown duration, then the lights come back on and the windshield, as in fairy tales, is already clean. We need a golden mean that provides sufficient feedback w/o overwhelming with details. I call it attention-friendly output, since human attention is a scarce commodity. |
I understand now, you're right. I just set
Please try the new binary: |
@sergeevabc How's the new version? |
@shenwei356, it crashes. I'm trying to understand the reason for the crash. $ brename.exe
Exception 0xc0000005 0x8 0x0 0x0
PC=0x0
runtime.asmstdcall()
/usr/local/go/src/runtime/sys_windows_amd64.s:65 +0x75 fp=0x22fca0 sp=0x22fc80 pc=0x46c355
rax 0x0
rbx 0xb8e3c0
rcx 0xbe34c0
rdi 0x7fffffde000
rsi 0x22fea0
rbp 0x22fde0
rsp 0x22fc78
r8 0x0
r9 0x22fee0
r10 0xbb5278
r11 0x21
r12 0x22fec0
r13 0x1
r14 0xb8dd60
r15 0x0
rip 0x0
rflags 0x10293
cs 0x33
fs 0x53
gs 0x2b |
Are you using Windows 7? Go 1.21 requires at least Windows 10 or Windows Server 2016. Try this one, compiled with Go1.20. |
Sure. I mentioned this in the first line of the current issue. I use Windows 7 and will continue to do so. The last OS which they tried to make polished enough to last, like a good hammer or wrist watch. What happened next was never meant to be a progress like before (NTFS instead of FAT32, for example), but a forced change of the profit model to software as a service (SaaS). It resembles the relationship between a drug dealer and an addict, to whom a weekly dose of patches is supplied to feel less anxious about a poorly made, but undeniably glossy OS. Your app deals with renaming files. I see no reason why it should stop working under Windows 7. Its descendants offer no breakthroughs related to files I/O. Go language developers want to look relevant, whereas I want apps to be future-proof. Think UNIX apps that are built to last across OSes w/o “do not touch after EOL” fearmongering. Back to bRename
|
We're definitely making some progress here, @shenwei356.
This message hangs on the screen for quite a long time when the app is running not on SSD, but on HDD. For a minute or so the disk buzzes like mad and we only know that some kind of check is underway. What kind of check is that? Let's explain it more clearly: “Looking for paths that match your pattern...”.
In the second case, the word “back" is missing. This is important because if there are many paths (think multiple screens of paths), then at the time of completion we no longer see the header “Renaming paths back...” and we might think that there was a renaming operation, not a restoration of names. Why is the timer so granular? Is it the Large Hadron Collider? Or Formula 1 racing? Or the Olympic games? I believe two decimal places is enough (45.86s). Do you have a wrist watch, how many decimal places are there? Also consider using seconds as the minimum unit of measurement (25.0014ms -> 0.02s) and add some humor when it is barely noticeable (<0.00s) like “renamed in the blink of an eye”. |
It's almost there. brename_windows_amd64.exe.tar.gz When searching a path with many sub-directories, the paths will be shown in one line and refreshed to tell users: "I'm working, just be patient and wait!" |
Recently, I found a new tool https://github.com/ayoisaiah/f2, which even supports Exif attributes~ You can also have a try. |
$ brename ...
Searching paths to rename...
Volume2\SoundsVolume2 Default Whiteerseorangeb\python38certifi1e8e3cd67arar
Renaming paths...
[DONE] Autohotkey\_os -> Autohotkey\_startup
[DONE] DNSCrypt\_os -> DNSCrypt\_startup
[DONE] Keepass\_os -> Keepass\_startup
3 path(s) renamed in 38.116 seconds
$ brename ...
Searching for paths to rename...
[DONE]
Renaming paths...
[DONE] Autohotkey\_os -> Autohotkey\_startup
[DONE] DNSCrypt\_os -> DNSCrypt\_startup
[DONE] Keepass\_os -> Keepass\_startup
3 path(s) renamed in 38.116 seconds
Good catch, @shenwei356! I have not tried this app in practice yet, but I immediately liked how it greets the user with things that you should consider adopting: the name, version, brief instruction, and a link where to get more information are given. |
All fixed. Thanks. |
Looks like you forgot to add the refreshing status to the dry-run |
I disable it for |
$ brename ... -d
Searching for paths to rename...
[OK] Autohotkey\_os -> Autohotkey\_osxxx
[OK] DNSCrypt\_os -> DNSCrypt\_osxxx
[OK] Keepass\_os -> Keepass\_osxxx
Done searching.
3 path(s) to be renamed 'Done searching' is kinda redundant on this screen and could be omitted because '3 path(s) to be renamed' line sums up the search, yes? |
Right. But here, "Done searching" is printed first, it might be due to different disk speeds.
Anyway, disabled it in dry-run mode. |
Congratulations, @shenwei356, brename's output looks much better now. |
Windows 7 x64 user here.
Except for the redundant checking and nerdy rather than vernacular presentation of renaming conditions with too much [INFO] SHOUTING, I'm happy with it. Especially considering that @shenwei356 implemented my proposal about undoing changes.
Now, let's update to 2.13 and see what happens.
This is what I expect to see:
The rest (timestamp, message type, renaming conditions, etc), if at all necessary, should be displayed if a dedicated flag is specified, thereby explicitly asking the app to increase the verbosity of logging.
The text was updated successfully, but these errors were encountered: