Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify art printing, make pingu infinite #12

Merged
merged 2 commits into from
Jun 18, 2022
Merged

Conversation

arnitdo
Copy link
Contributor

@arnitdo arnitdo commented Jun 13, 2022

  1. Added a carriage return \r character before printing pingu art. This will ensure that all user-typed characters are cleared, and pingu art is printed from the start of the line.

Before, Art is distorted 😦

Pingu - Before

After, Art is consistent and clean 😃

Pingu - After

  1. Changed display logic, so that pingu is displayed repeatedly, not once

Before, Single Pingu

Pingu - Before

After, Many Pingu!

Pingu - After

@icovada
Copy link

icovada commented Jun 17, 2022

Another option to get a truly infinite pingu is to repeat the last line of the ascii art to get a "longu"

@arnitdo
Copy link
Contributor Author

arnitdo commented Jun 17, 2022

Another option to get a truly infinite pingu is to repeat the last line of the ascii art to get a "longu"

@icovada We could also extend the pingu art upto the legs, thereby reducing the repeatedness of the art. Let's see what sheepla has to say about this.

@sheepla
Copy link
Owner

sheepla commented Jun 18, 2022

@arnitdo Thank you for fixing and improving the display. Infinite ASCII art is a very fun feature! 😆
@icovada I thought longu is also fun! but I want to adopt infinite ASCII art! Thank you for the fun idea. 👍

@sheepla sheepla merged commit 3386e84 into sheepla:master Jun 18, 2022
sheepla added a commit that referenced this pull request Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants