Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #66

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Fix CI #66

merged 4 commits into from
Jul 17, 2024

Conversation

AHOHNMYC
Copy link
Contributor

  • Updated actions to use node20
  • Updated vcpkg slice to capture new libgit2 1.8.0 with fetch depth options
  • Added setup-msbuild action as msbuild doesn't exist on runner out of the box

* Updated actions to use node20
* Updated vcpkg slice to capture new libgit2 1.8.0 with fetch depth options
* Added `setup-msbuild` action as msbuild doesn't exist on runner out of the box
@AHOHNMYC AHOHNMYC marked this pull request as draft July 17, 2024 16:30
@shdwmtr
Copy link
Owner

shdwmtr commented Jul 17, 2024

What's the reasoning behind truncating the version in ./version

@AHOHNMYC
Copy link
Contributor Author

AHOHNMYC commented Jul 17, 2024

There is no reason. I guess, its because of broken autoversion in cloned repo without releases. I'll restore status quo when PR will be ready to merge

@shdwmtr
Copy link
Owner

shdwmtr commented Jul 17, 2024

I've made a new commit where explicitly specify the version of libgit2 without updating the vcpkg baseline, to prevent side effects.

@shdwmtr shdwmtr marked this pull request as ready for review July 17, 2024 22:41
@AHOHNMYC
Copy link
Contributor Author

AHOHNMYC commented Jul 17, 2024

Yeah, I got it when saw Resolve conflicts 😄 Nice job. I'll revert all about libgit2 and stuff

What about other changes? In my cloned repo I haven't success Windows build untill I've added setup-msbuild. My guess is GitHub Action caches in your repo.

@shdwmtr
Copy link
Owner

shdwmtr commented Jul 17, 2024

Yeah, you're totally right. I must have changed something removing the setup of MS build, but I didn't matter at the time because it was already cached. Good thing you caught it.

@shdwmtr
Copy link
Owner

shdwmtr commented Jul 17, 2024

Just revert the changes made to vcpkg-configuration.json and version and it should be good to merge. Also, just checking, your proposed changes to vcpkg is just a submodule update correct? GitHub doesn't provide much information.

@shdwmtr shdwmtr merged commit 8123684 into shdwmtr:main Jul 17, 2024
Copy link

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@shdwmtr
Copy link
Owner

shdwmtr commented Jul 17, 2024

Something seems to have messed up in one of these commits. It seems libgit2 isn't being statically linked and its requiring zlib1.dll. It builds correctly locally, but not from the CI

shdwmtr added a commit that referenced this pull request Jul 18, 2024
This reverts commit 8123684, reversing
changes made to 6feced6.
shdwmtr added a commit that referenced this pull request Jul 18, 2024
Potentially causing issues with static linking
@shdwmtr
Copy link
Owner

shdwmtr commented Jul 18, 2024

Not entirely sure what caused it, but it seems one of our recent commits messed up Millennium. Its been fixed but I've reverted your changes.

@AHOHNMYC AHOHNMYC deleted the update_libgit2 branch July 18, 2024 14:07
@AHOHNMYC
Copy link
Contributor Author

Oh, okay. Sadly it's expected. I'm thinking about little exe loader with bunch of self tests...

@shdwmtr
Copy link
Owner

shdwmtr commented Aug 10, 2024

Oops, missed your message, GitHub decided it wasn't going to notify me. That's a great idea and its been something I've wanted to do however I just didnt have time to focus on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants