-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #66
Fix CI #66
Conversation
What's the reasoning behind truncating the version in |
There is no reason. I guess, its because of broken autoversion in cloned repo without releases. I'll restore status quo when PR will be ready to merge |
I've made a new commit where explicitly specify the version of libgit2 without updating the vcpkg baseline, to prevent side effects. |
Yeah, I got it when saw What about other changes? In my cloned repo I haven't success Windows build untill I've added |
Yeah, you're totally right. I must have changed something removing the setup of MS build, but I didn't matter at the time because it was already cached. Good thing you caught it. |
Just revert the changes made to |
🎉 This issue has been resolved in version 2.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Something seems to have messed up in one of these commits. It seems libgit2 isn't being statically linked and its requiring zlib1.dll. It builds correctly locally, but not from the CI |
Potentially causing issues with static linking
Not entirely sure what caused it, but it seems one of our recent commits messed up Millennium. Its been fixed but I've reverted your changes. |
Oh, okay. Sadly it's expected. I'm thinking about little exe loader with bunch of self tests... |
Oops, missed your message, GitHub decided it wasn't going to notify me. That's a great idea and its been something I've wanted to do however I just didnt have time to focus on it. |
setup-msbuild
action as msbuild doesn't exist on runner out of the box