Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Millennium requires opening up Steam twice to start successfully #149

Closed
3 tasks done
Jonius7 opened this issue Oct 28, 2024 · 22 comments
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@Jonius7
Copy link

Jonius7 commented Oct 28, 2024

Before Reporting

  • I found no existing issues matching my bug
  • My issue is not caused by a theme
  • My issue is not caused by a plugin

Describe the Bug

Been using v2.12.4 for a while and I find I need to start up Steam twice for it to open properly as the first time it crashes or doesn't show any Steam windows.

Below is the -dev console when Steam is run for the first time, something about a Promise already satisfied

2024-10-28 17_24_32-Millennium@v2 12 4

Expected Behavior

Start up Steam
See login screen and then Steam window the first time

Steps To Reproduce

Windows 11, with Inject JavaScript and Inject StyleSheets enabled, and these themes/skins:

  • ATOMS
  • Classic Steam Library
  • Metro by Rose
  • OldGlory
  • Simple Dark.
  • SpaceTheme for Steam

Operating System

Windows

Anything else?

No response

@Jonius7 Jonius7 added the bug Something isn't working label Oct 28, 2024
@shdwmtr
Copy link
Owner

shdwmtr commented Oct 28, 2024

I've seemingly fixed this, it will be in the latest update. Steam added something in the newest beta that causes this. I'll leave this open until I'm confident its fixed.

@NathanL1370
Copy link

NathanL1370 commented Oct 28, 2024

I can confirm I am having this issue too. This is also occurring occasionally on the stable branch, and it can also happen with the default theme.

@shdwmtr
Copy link
Owner

shdwmtr commented Oct 29, 2024

@NathanL1370 @Jonius7

Try using this version, see if it fixes it.
https://nightly.link/SteamClientHomebrew/Millennium/actions/runs/11566730508

Extract the files in your steam folder and replace all (make sure Steam is closed)
built from source here

@NathanL1370
Copy link

Seems like it's fixed after trying the version from the nightly link. Restarts also seem to work properly now, including the default and other themes.

@shdwmtr
Copy link
Owner

shdwmtr commented Oct 29, 2024

Perfect; after some more slight bug testing I'll release that version. You can use that version as normal in the time being ofc.

@YCZ01111
Copy link

YCZ01111 commented Nov 2, 2024

I found that after starting Windows for a period of time, Steam can start successfully in one go. If you run Steam right after starting Windows, you will need to run it twice.

@shdwmtr
Copy link
Owner

shdwmtr commented Nov 2, 2024

Fixed in the latest release!

@shdwmtr shdwmtr closed this as completed Nov 2, 2024
@YCZ01111
Copy link

YCZ01111 commented Nov 3, 2024

I have updated to 2.13.0, but there is still this issue

@NathanL1370
Copy link

NathanL1370 commented Nov 3, 2024

Issue is still happening after updating to 2.13.0 on Windows.
Uninstalling and reinstalling Millennium does not fix the issue; now Steam won't start up at all, nor will it appear in my system tray. It briefly shows up in task manager, but then quits itself after about ~20 seconds.

@shdwmtr
Copy link
Owner

shdwmtr commented Nov 3, 2024

@NathanL1370 start steam with -dev and share the console output. Btw I thought you said the nightly link fixed your issue?

@shdwmtr shdwmtr reopened this Nov 3, 2024
shdwmtr added a commit that referenced this issue Nov 3, 2024
@shdwmtr
Copy link
Owner

shdwmtr commented Nov 3, 2024

@YCZ01111 @NathanL1370 give this a try. Just extract and replace in the steam folder
https://github.com/SteamClientHomebrew/Millennium/actions/runs/11648759524

@NathanL1370
Copy link

NathanL1370 commented Nov 3, 2024

@NathanL1370 start steam with -dev and share the console output. Btw I thought you said the nightly link fixed your issue?

Screenshot 2024-11-02 222904

Console output now throws a system error in v2.13.0, with the what() function saying that a resource is temporarily unavailable.
The nightly link didn't have this problem. But now it is, in v2.13.0.

@NathanL1370
Copy link

@shdwmtr Forgot to include this screenshot, but when I tried using your compiled version of Millennium, the console output warns that it's "upgrading" from 2.13.1 to 2.13.0, which still has the bug. (Technically, wouldn't it be downgrading in this case?)
Steam was started with -dev.
Screenshot 2024-11-02 223941

@shdwmtr
Copy link
Owner

shdwmtr commented Nov 3, 2024

Ah oopsies, it's downloading the live version. Set check_for_updates to no in C:\Program Files (x86)\Steam\ext\millennium.ini for testing (and revert back when necessary). Then install the build above

@NathanL1370
Copy link

Trying again with 3 launch attempts, console still throws std::system_error.
Screenshot 2024-11-02 231030
Screenshot 2024-11-02 231049
Screenshot 2024-11-02 231116

@shdwmtr
Copy link
Owner

shdwmtr commented Nov 3, 2024

I seem to be able to reproduce it, its because you have a large amount of files in your steamui folder in steam that slows down Millenniums start process resulting in a race condition. Where it says connected to SharedJSContext in 7000 ms it should be 1-2 ms

@shdwmtr
Copy link
Owner

shdwmtr commented Nov 3, 2024

It seems I wasn't properly freeing a thread. This should fix it https://github.com/SteamClientHomebrew/Millennium/actions/runs/11654025051

@NathanL1370
Copy link

I seem to be able to reproduce it, its because you have a large amount of files in your steamui folder in steam that slows down Millenniums start process resulting in a race condition. Where it says connected to SharedJSContext in 7000 ms it should be 1-2 ms

That was my actual issue upon further inspection in my steamui folder, it seems I had a bunch of skin backup folders that were probably created in a very old version of Millennium.

@NathanL1370
Copy link

Seems to be working now after trying your hotfixed version.
Console output also reports that the UI has loaded successfully as well. Restarts are working properly as it should.
Screenshot 2024-11-03 113127

@shdwmtr
Copy link
Owner

shdwmtr commented Nov 3, 2024

try restoring those files to see if it works even with them in there now (if you havent deleted them permanently)

@NathanL1370
Copy link

NathanL1370 commented Nov 3, 2024

try restoring those files to see if it works even with them in there now (if you havent deleted them permanently)

Seems like it still works, it's just that Steam will end up taking longer to start with the files still present.

Before:
Screenshot 2024-11-03 114321
After:
Screenshot 2024-11-03 114408

@shdwmtr
Copy link
Owner

shdwmtr commented Nov 3, 2024

Perfect! I plan to move skins outside of the steamui folder in the future because Steam pre-caches everything in the folder which takes a long time (happens with or without Millennium), but that's an issue for another time.

@shdwmtr shdwmtr closed this as completed Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants