Add additional perf counters for stalled frontend/backend cycles (pro…

…metheus#2191) * Add stalled frontend/backend cycles counters for perf collector Signed-off-by: Daniel Hodges <[email protected]> * Update collector/perf_linux.go Co-authored-by: Ben Kochie <[email protected]> Signed-off-by: Daniel Hodges <[email protected]> * Update collector/perf_linux.go Co-authored-by: Ben Kochie <[email protected]> Signed-off-by: Daniel Hodges <[email protected]> Co-authored-by: Ben Kochie <[email protected]>
shatteredsilicon · Apr 9, 2024 · 2684183 · 2684183
1 parent 0056e1f
commit 2684183
Showing 1 changed file with 45 additions and 0 deletions.
diff --git a/collector/perf_linux.go b/collector/perf_linux.go
@@ -397,6 +397,26 @@ func NewPerfCollector(logger log.Logger) (Collector, error) {
 			[]string{"cpu"},
 			nil,
 		),
+		"stalled_cycles_backend_total": prometheus.NewDesc(
+			prometheus.BuildFQName(
+				namespace,
+				perfSubsystem,
+				"stalled_cycles_backend_total",
+			),
+			"Number of stalled backend CPU cycles",
+			[]string{"cpu"},
+			nil,
+		),
+		"stalled_cycles_frontend_total": prometheus.NewDesc(
+			prometheus.BuildFQName(
+				namespace,
+				perfSubsystem,
+				"stalled_cycles_frontend_total",
+			),
+			"Number of stalled frontend CPU cycles",
+			[]string{"cpu"},
+			nil,
+		),
 		"page_faults_total": prometheus.NewDesc(
 			prometheus.BuildFQName(
 				namespace,
@@ -598,6 +618,9 @@ func (c *perfCollector) updateHardwareStats(ch chan<- prometheus.Metric) error {
 		if err := (*profiler).Profile(hwProfile); err != nil {
 			return err
 		}
+		if hwProfile == nil {
+			continue
+		}
 
 		cpuid := strconv.Itoa(c.hwProfilerCPUMap[profiler])
 
@@ -656,6 +679,22 @@ func (c *perfCollector) updateHardwareStats(ch chan<- prometheus.Metric) error {
 				cpuid,
 			)
 		}
+
+		if hwProfile.StalledCyclesBackend != nil {
+			ch <- prometheus.MustNewConstMetric(
+				c.desc["stalled_cycles_backend_total"],
+				prometheus.CounterValue, float64(*hwProfile.StalledCyclesBackend),
+				cpuid,
+			)
+		}
+
+		if hwProfile.StalledCyclesFrontend != nil {
+			ch <- prometheus.MustNewConstMetric(
+				c.desc["stalled_cycles_frontend_total"],
+				prometheus.CounterValue, float64(*hwProfile.StalledCyclesFrontend),
+				cpuid,
+			)
+		}
 	}
 
 	return nil
@@ -667,6 +706,9 @@ func (c *perfCollector) updateSoftwareStats(ch chan<- prometheus.Metric) error {
 		if err := (*profiler).Profile(swProfile); err != nil {
 			return err
 		}
+		if swProfile == nil {
+			continue
+		}
 
 		cpuid := strconv.Itoa(c.swProfilerCPUMap[profiler])
 
@@ -720,6 +762,9 @@ func (c *perfCollector) updateCacheStats(ch chan<- prometheus.Metric) error {
 		if err := (*profiler).Profile(cacheProfile); err != nil {
 			return err
 		}
+		if cacheProfile == nil {
+			continue
+		}
 
 		cpuid := strconv.Itoa(c.cacheProfilerCPUMap[profiler])