New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code for u8 byte read #342

Closed

wcampbell0x2a wants to merge 1 commit into master from reduce-u8-byte-deku-read-code

Collaborator

wcampbell0x2a commented Jun 6, 2023

I think I was a bit over-eager with the fix within #294.

The following pasts test. unless you can come up with a test that doesn't pass!


          Reduce code for u8 byte read

47b2f7e

github-actions bot commented Jun 6, 2023

Benchmark for `2a98e11`

Click to view benchmark

Test	Base	PR	%
deku_read_bits	701.3±5.97ns	694.4±0.47ns	-0.98%
deku_read_byte	19.9±0.09ns	12.4±0.06ns	-37.69%
deku_read_enum	35.6±0.16ns	20.0±0.07ns	-43.82%
deku_read_vec	1696.8±3.75ns	954.2±4.92ns	-43.76%
deku_read_vec_perf	1665.4±1.08ns	940.0±8.47ns	-43.56%
deku_write_bits	130.6±0.08ns	131.0±0.13ns	+0.31%
deku_write_byte	74.4±0.45ns	71.9±0.91ns	-3.36%
deku_write_enum	126.5±0.82ns	120.8±0.62ns	-4.51%
deku_write_vec	5.7±0.01µs	5.4±0.00µs	-5.26%
deku_write_vec_perf	5.8±0.00µs	5.4±0.01µs	-6.90%

wcampbell0x2a mentioned this pull request

Impl from_reader #352

Merged

8 tasks

wcampbell0x2a closed this

wcampbell0x2a deleted the reduce-u8-byte-deku-read-code branch

August 12, 2023 03:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet