Prevent --terminal-width=0
and invalid forms of --terminal-width
.
#559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposed solution to #535, which involves validating
--terminal-width
to report an error if somebody provides a width of zero.Why this approach, and not having it disable wrapping?
User convenience is definitely something to consider, but in this instance I believe having
--terminal-width=0
being analogous to--wrap=never
would be more of a quirky behaviour than a quality-of-life feature.--terminal-width
.--terminal-width=0
as--wrap=never
isn't very clear or intuitive.--terminal-width=0
as a way to disable wrapping results in a conflict when you don't want wrapping, but do want to specify a specific terminal width.--wrap=never
.