When specifying style multiple times the last occurence wins #371

sindreij · 2018-10-21T13:28:26Z

Closes: #367

sharkdp · 2018-10-21T20:17:05Z

src/clap_app.rs

+                .overrides_with("plain")
+                .overrides_with("number")
+                // Cannot use clap's built in validation because we have to turn off clap's delimiters
+                .validator(|val| {


sharkdp · 2018-10-21T20:20:38Z

Awesome, thank you very much for your contribution!

I had to remove clap's splitting of the arguments in style. When using clap's splitting with overriding, it only keep the last one in the set. So --style numbers,changes becomes changes.

Yes, a little bit unfortunate, but I think your solution is the only way to handle this.

sindreij added 3 commits October 21, 2018 15:27

When specifying style multiple times the last occurence wins

dc90a66

Closes: sharkdp#367

Rustfmt

12c884f

Only use the last argument of {style,plain,number}

6e32574

sindreij mentioned this pull request Oct 21, 2018

Allow for multiple occurences of "--style" #367

Closed

sharkdp reviewed Oct 21, 2018

View reviewed changes

Remove commented-out code

3fafe22

sharkdp approved these changes Oct 21, 2018

View reviewed changes

sharkdp merged commit abcd09f into sharkdp:master Oct 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When specifying style multiple times the last occurence wins #371

When specifying style multiple times the last occurence wins #371

sindreij commented Oct 21, 2018

sharkdp Oct 21, 2018

sharkdp commented Oct 21, 2018

When specifying style multiple times the last occurence wins #371

When specifying style multiple times the last occurence wins #371

Conversation

sindreij commented Oct 21, 2018

sharkdp Oct 21, 2018

Choose a reason for hiding this comment

sharkdp commented Oct 21, 2018