-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alias for --paging=never #1082
Conversation
I think the long flag would be better as @sharkdp, thoughts? |
I agree on the naming. Currently there is no long flag, but I'm happy to add that |
Thank you very much for your contribution. Code looks good - thank you for adding the tests. As for the long option, I'm not sure if we really need that. We already have Could you please add an entry to the "unreleased" section in the
where The man page should also be updated. |
Hmm, fair point on the long option, although the
|
You are right. I think I would still rather keep the |
A long alias doesn't make sense, since `--paging=never` already exists
I've pulled the long argument and hidden it so it doesn't show up in the help page. I also made a few changes to the pager and paging descriptions in the man page, but I can change it back if I made anything unclear. Also, as a topic for another issue: adding an environment section to the man page |
Thank you very much for the updates and the high quality PR! |
From #1075, here's my proposed implementation for adding an alias for
--paging=never
.I couldn't find a way for clap to create an alias with a value, so I ended up creating a new parameter for it.
I'm not sure if it needs to be added, but I figure I'll share it anyways. I'm not sold on using
-P
as the flag, but it made the most sense to me.