Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fish shell completions. #104

Closed
wants to merge 1 commit into from
Closed

Conversation

eth-p
Copy link
Collaborator

@eth-p eth-p commented May 12, 2018

Added some completions for fish shell.

@sharkdp
Copy link
Owner

sharkdp commented May 12, 2018

Thanks!

There is a way to auto-generate completion files for bash, zsh, fish and PowerShell via clap (see for example: https://github.com/sharkdp/fd/pull/66/files, https://github.com/sharkdp/fd/blob/master/build.rs) which I would prefer in order tp prevent maintenance overhead.

What do you think?

@eth-p
Copy link
Collaborator Author

eth-p commented May 12, 2018

That's a pretty cool feature! Automatically generating completion files would definitely be the way to go.

@sharkdp
Copy link
Owner

sharkdp commented May 14, 2018

I hope it's okay if I close this PR. I have opened #115 to track the addition of auto-generated completion files.

Thank you very much for your contribution.

@sharkdp sharkdp closed this May 14, 2018
@eth-p eth-p deleted the completions branch September 8, 2018 23:16
@sboukortt
Copy link

Unfortunately, the generated fish completion does not complete filenames, and so pressing Tab does nothing for them. That’s sufficiently annoying that I simply deleted the completion file on my machine.

@sharkdp
Copy link
Owner

sharkdp commented Oct 21, 2018

@sboukortt Oh ☹️. Could you please open a new ticket to address this?

@sboukortt
Copy link

Done (#372), thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants