Admin acts as another user #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aivils
force-pushed
the
admin-acts-as-another-user
branch
from
34cfa7b to
c682823
Compare
bladealslayer
requested changes
Jan 3, 2019
app/presenters/listing_presenter.rb
Outdated
| @@ -288,5 +289,30 @@ def payments_enabled? | |||
| process == :preauthorize | |||
| end | |||
|
|
|||
| def acts_as_person | |||
| params[:person_id].present? ? Person.find_by!(username: params[:person_id]) : nil | |||
There was a problem hiding this comment.
Might want to add community_id in the find_by! just in case.
| @@ -488,4 +500,8 @@ def create_booking(shape, listing_uuid) | |||
| true | |||
| end | |||
| end | |||
|
|
|||
| def new_listing_author | |||
| @new_listing_author ||= params[:person_id].present? ? Person.find_by!(username: params[:person_id]) : @current_user | |||
There was a problem hiding this comment.
Make sure find_by! also includes community_id!
aivils
force-pushed
the
admin-acts-as-another-user
branch
from
c682823 to
964a81a
Compare
aivils
force-pushed
the
admin-acts-as-another-user
branch
from
964a81a to
8a7d553
Compare
|
@bladealslayer |
|
@aivils you could still add test case with two marketplaces where admin of one can't post listing as user of another marketplace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.