Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Braintree #2424

Merged
merged 67 commits into from
Aug 23, 2016
Merged

Remove Braintree #2424

merged 67 commits into from
Aug 23, 2016

Conversation

kpuputti
Copy link
Contributor

@kpuputti kpuputti commented Aug 18, 2016 •
edited
Loading

TODO

  • Restore Braintree translations that are using by PayPal
  • Grep :paypal and check all if/else branches and possibly raise exceptions in else branches
  • Remove VAT (communities.vat column and maybe some related code?)
  • Remove PaymentsController
  • Remove PostPayTransactionController
  • Grep "post_pay" and "PostPay"
  • Remove postpay steps from the statemachine
  • Grep "escrow"
  • Grep "invoice"
  • Grep and remove "payment_reminder"
  • Grep "community.payment_gateway"
  • Remove transaction has_one payment
  • Remove community.has_one payment_gateway
  • Remove testimonials_in_use code

@kpuputti kpuputti force-pushed the remove-braintree branch 2 times, most recently from 0d4def9 to 5f7e8ca Compare August 23, 2016 06:51
ovan
ovan reviewed Aug 23, 2016
View reviewed changes
app/controllers/people_controller.rb
:email_about_confirm_reminders,
:email_about_testimonial_reminders,
:email_about_completed_transactions,
:email_about_new_payments,
:email_about_payment_reminders,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this only about postpay too? There's payments in every flow, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No wait, I get it, in prepay there's no tx process without payment.

rap1ds and others added 25 commits August 23, 2016 13:46
@rap1ds
Remove payment settings path/url helpers
fe440e9
@rap1ds
Remove PaymentRegisterationGuard
13bb95b
@rap1ds
Remove Braintree disable hack from ListingsController
59461c9
@rap1ds
Remove AcceptController's accept action
ca4c01f
@rap1ds
Remove AcceptConversationController
d4e7a82
@rap1ds
Remove two failing tests
7dd7396
@rap1ds
Grep :braintree and remove code
3bc556f
@rap1ds
Grep Braintree and remove code
e3a06e3
@rap1ds
Remove Braintree gem
89d57d5
@rap1ds
Remove BraintreeAccount and BraintreePayment models
f805acf
@rap1ds
Remove payment reminders
9dfbc8c
@rap1ds
Remove Payment model
1ccf8ac
@rap1ds
Remove PaymentGateway model
2733d0b
@kpuputti @rap1ds
Add missing Braintree translations back
4b17111
@rap1ds
Remove PaymentsController
479add8
@rap1ds
Grep "escrow" and remove code
1723957
@rap1ds
Remove everything related to postpay
8d73377
@kpuputti @rap1ds
Remove VAT
c724355
@rap1ds
Remove accepted and pending states from transaction state machine
c337eea
@kpuputti @rap1ds
Remove community.payment_gateway usages
b3eaca3
@rap1ds
Fix broken RSpec tests
b30097a
@kpuputti @rap1ds
Remove payment attr
3786e9a
@kpuputti @rap1ds
Remove community.testimonials_in_use
7216b1d
@rap1ds
Restore some code so that we handle old transactions in deprecated st…
0893af0 
…ates
@rap1ds
Use Free payment gateway adapter for Checkout Finland and Braintree
6e51d06
ovan
ovan reviewed Aug 23, 2016
View reviewed changes
app/services/transaction_service/transaction.rb
# Deprecated adapters.
# We need these to be here, otherwise reading the old transactions will fail
checkout: TransactionService::Gateway::FreeAdapter.new,
braintree: TransactionService::Gateway::FreeAdapter.new,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you think about solving this at the origin of the failure instead of providing fake adapters?

@kpuputti kpuputti merged commit 0576ef4 into master Aug 23, 2016
@kpuputti kpuputti deleted the remove-braintree branch August 23, 2016 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpuputti @ovan @rap1ds