Move confirmation_pending to CommunityMemberships controller #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oller - [X] Move confirmation_pending to a more logical place - [X] Redirect to root if user is already accepted
rap1ds
force-pushed
the
clean-sessions-controller
branch
from
304d731 to
262035e
Compare
|
Looks good. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge this only after #1960
This PR moves
confirmation_pendingaction fromSessionsControllertoCommunityMembershipscontroller.pending_email_confirmationis one of the membership statuses, so it makes sense to have the action inCommunityMembershipscontroller. It has nothing to do with session creation, because session has been created already before user sees this page.This PR also fixes one small but super annoying bug in the app:
Steps to reproduce:
Expected result: You are redirected to front-page. You see a message which says that you are already a member.
Actual result: No redirect. The page looks a bit broken because the email is missing.