Review markups

share · Nov 20, 2019 · c0e9e0b · c0e9e0b
1 parent 751728c
commit c0e9e0b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 26 deletions.
diff --git a/lib/error.js b/lib/error.js
@@ -1,19 +1,16 @@
 function ShareDBError(code, message) {
-  this.name = 'ShareDBError';
-  this.code = code || ShareDBError.CODES.ERR_UNKNOWN_ERROR;
-  this.message = message;
-  if (this.canCaptureStackTrace()) {
+  this.code = code;
+  this.message = message || '';
+  if (Error.captureStackTrace) {
     Error.captureStackTrace(this, ShareDBError);
   } else {
     this.stack = new Error().stack;
   }
 }
 
 ShareDBError.prototype = Object.create(Error.prototype);
-
-ShareDBError.prototype.canCaptureStackTrace = function() {
-  return !!Error.captureStackTrace;
-};
+ShareDBError.prototype.constructor = ShareDBError;
+ShareDBError.prototype.name = 'ShareDBError';
 
 ShareDBError.CODES = {
   ERR_APPLY_OP_VERSION_DOES_NOT_MATCH_SNAPSHOT: 'ERR_APPLY_OP_VERSION_DOES_NOT_MATCH_SNAPSHOT',

diff --git a/test/error.js b/test/error.js
@@ -1,12 +1,7 @@
 var ShareDBError = require('../lib/error');
 var expect = require('chai').expect;
-var sinon = require('sinon');
 
 describe('ShareDBError', function() {
-  afterEach(function() {
-    sinon.restore();
-  });
-
   it('can be identified by instanceof', function() {
     var error = new ShareDBError();
     expect(error).to.be.instanceof(ShareDBError);
@@ -33,17 +28,4 @@ describe('ShareDBError', function() {
       expect(error.stack).to.contain('badFunction');
     }
   });
-
-  it('has a stack trace when Error.captureStackTrace is not implemented', function() {
-    sinon.stub(ShareDBError.prototype, 'canCaptureStackTrace').returns(false);
-    function badFunction() {
-      throw new ShareDBError();
-    }
-
-    try {
-      badFunction();
-    } catch (error) {
-      expect(error.stack).to.contain('badFunction');
-    }
-  });
 });