Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: only show rate changed on unfavorable change #8905

Merged
merged 3 commits into from
Feb 20, 2025
Merged

feat: only show rate changed on unfavorable change #8905

merged 3 commits into from
Feb 20, 2025

Conversation

gomesalexandre
Copy link
Contributor

Description

Quite literally what the box says, this does!

Issue (if applicable)

closes #8867

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low to none

Testing

  • Test a few rates/quotes and ensure you only see the rate changed modal on unfavorable change (CoW seemingly yields one consistently on a smol USDC->FOX on Arb, to help with testing!)

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

https://jam.dev/c/b8668a41-66b8-46e2-961f-8393b3eba74e

@gomesalexandre gomesalexandre requested a review from a team as a code owner February 20, 2025 18:33
@gomesalexandre gomesalexandre merged commit 1f63010 into develop Feb 20, 2025
3 checks passed
@gomesalexandre gomesalexandre deleted the feat_unfavorable_rate_changed branch February 20, 2025 21:03
@gomesalexandre gomesalexandre mentioned this pull request Feb 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaladinlight kaladinlight kaladinlight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove rate changed ack when the rate change is favorable to user
2 participants
@gomesalexandre @kaladinlight