Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: account selection fixes and improvements #8902

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Feb 20, 2025

Description

  • adds copy button for non-UTXO accounts (since there is not a single address to copy for UTXOs except for the xpub which you definitely don't want to copy thinking it's an addy)
  • fixes wrong label used for UTXOs and uses the asset name instead

Issue (if applicable)

closes #8899
closes #8838

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low

Testing

  • Non-UTXO accounts are copy-able in account selection, next to the addy
  • UTXO accounts are not copy-able in account selection
  • UTXO accounts display their name in the top-level account number view in account selection

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

Screenshot 2025-02-20 at 15 30 22 Screenshot 2025-02-20 at 15 30 28 Screenshot 2025-02-20 at 15 30 28

@gomesalexandre gomesalexandre marked this pull request as ready for review February 20, 2025 14:37
@gomesalexandre gomesalexandre requested a review from a team as a code owner February 20, 2025 14:37
@kaladinlight
Copy link
Contributor

suggestion - could we have the copy button next to the address instead of amount to make more sense?

Copy link
Contributor Author

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after b3c8371 @kaladinlight
image
image

@gomesalexandre gomesalexandre enabled auto-merge (squash) February 20, 2025 20:57
@gomesalexandre gomesalexandre merged commit b5fc012 into develop Feb 20, 2025
3 checks passed
@gomesalexandre gomesalexandre deleted the feat_account_select_things branch February 20, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong and/or redundant script type label in UTXO account selector Make addresses copiable
2 participants