Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove thorswap discount dead code #8900

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Conversation

NeOMakinG
Copy link
Collaborator

Description

This code is disabled and shouldn't be enabled now so, it's time to clean it!

Issue (if applicable)

n/a

Risk

Low

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

In reality nothing, but you could try big swaps or just smoke test swapper

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

https://jam.dev/c/93faff8f-17ac-449f-b7af-f197ee3c2e36

@NeOMakinG NeOMakinG requested a review from a team as a code owner February 20, 2025 14:18
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke test looking gucci, hasta la vista baby 🩸
https://jam.dev/c/9df43e9c-6262-423c-9647-7f34c78594d9

@0xApotheosis 0xApotheosis merged commit eec5bf2 into develop Feb 20, 2025
3 checks passed
@0xApotheosis 0xApotheosis deleted the clear-thorswap branch February 20, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants