Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consistent runepool read-only behaviour #8889

Merged
merged 13 commits into from
Feb 20, 2025
Merged

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Feb 19, 2025

Description

RUNEPool is no different than other savers, it's going away in prop6 with funds going into DLP.
Yes, the only diffence with savers is you can still deposit, but we don't want our users to be rugged by depositing and then being stuck.
As such, make its flow consistent with savers.

Issue (if applicable)

closes #8880

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None

Testing

  • RUNEPool has the same "only display if active" behaviour as savers
  • RUNEPool "View" takes to the same link as savers

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

image

@gomesalexandre gomesalexandre requested a review from a team as a code owner February 19, 2025 15:13
@gomesalexandre gomesalexandre changed the title feat: init rm feat: consistent runepool read-only behaviour Feb 19, 2025
@gomesalexandre gomesalexandre changed the base branch from develop to feat_by_asset_2 February 19, 2025 15:14
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gm

Base automatically changed from feat_by_asset_2 to develop February 20, 2025 10:02
@gomesalexandre gomesalexandre merged commit d910d2f into develop Feb 20, 2025
3 checks passed
@gomesalexandre gomesalexandre deleted the feat_by_asset_2-1 branch February 20, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning on ThorFi needs updating
2 participants