Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show thorchain lp warning only if pools are enabled and enable them #8886

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

NeOMakinG
Copy link
Collaborator

Description

Seems like we finally want to enable LP deposits again #8740

Also we should show the warning only if LP deposits are enabled

Issue (if applicable)

closes #8882

Risk

Low

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • See if LP deposits are enabled again
  • See if refund warnings are displayed
  • If you disable the LP deposit flag, it shouldn't be shown anymore

Engineering

n/a

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

Flag enabled

image
image
image

LP Deposit flag disabled

image
image
image

@NeOMakinG NeOMakinG requested a review from a team as a code owner February 19, 2025 08:28
@gomesalexandre gomesalexandre self-requested a review February 19, 2025 10:11
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gomesalexandre gomesalexandre merged commit 2ba7679 into develop Feb 19, 2025
3 checks passed
@gomesalexandre gomesalexandre deleted the lp-instability-flag-fix branch February 19, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LP's have a warning to proceed with caution but LP's are halted in production
2 participants