Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid regenerating mnemonics on back button hit #8885

Merged
merged 12 commits into from
Feb 19, 2025

Conversation

NeOMakinG
Copy link
Collaborator

@NeOMakinG NeOMakinG commented Feb 19, 2025

Description

If you go back from backup test, the mnemonic should be the same as previously selected

If you go back after successfuly passing the test, the mnemonic should be a new one as it's sealed

Issue (if applicable)

closes #8874

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Try to create a new wallet
  • Go back from one of the back up test
  • Verify the mnemonic, it should be the same
  • It should change only if you come from another page or from the wallet password/name screen as you already saved this mnemonic somewhere

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

https://jam.dev/c/ea989cb5-7bb3-40d7-9e33-2cc9503ab391

@NeOMakinG NeOMakinG marked this pull request as ready for review February 19, 2025 09:46
@NeOMakinG NeOMakinG requested a review from a team as a code owner February 19, 2025 09:46
@gomesalexandre gomesalexandre self-requested a review February 19, 2025 10:06
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM! Some non-blocking comments to tackle at your convenience

https://jam.dev/c/f975e7d5-18a2-4fee-bb80-8ac5c22d0e5c

@NeOMakinG NeOMakinG force-pushed the back-seed-regenerate branch from 8acdb4a to d8091b3 Compare February 19, 2025 14:24
@NeOMakinG NeOMakinG enabled auto-merge (squash) February 19, 2025 14:24
@NeOMakinG NeOMakinG merged commit e0c2281 into develop Feb 19, 2025
3 checks passed
@NeOMakinG NeOMakinG deleted the back-seed-regenerate branch February 19, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking back on backup flow creates a new mnemonic
2 participants