fix: handle undefined options in number abbrev (#3860)

shapeshift · Feb 23, 2023 · 9d1b22c · 9d1b22c
1 parent 4ae2a06
commit 9d1b22c
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/hooks/useLocaleFormatter/useLocaleFormatter.ts b/src/hooks/useLocaleFormatter/useLocaleFormatter.ts
@@ -187,14 +187,19 @@ export const useLocaleFormatter = (args?: useLocaleFormatterArgs): NumberFormatt
         minimumFractionDigits,
         lessThanMin ? 6 : getFiatNumberFractionDigits(number),
       )
+      // Filter out undefined options caused by optional component props so they do not override the defaults
+      const filteredOptions = options
+        ? Object.fromEntries(Object.entries(options).filter(([_, value]) => value !== undefined))
+        : {}
       const formatter = new Intl.NumberFormat(deviceLocale, {
         notation: number < bounds.min || noDecimals ? 'standard' : 'compact',
         compactDisplay: fiatType || number < longCompactDisplayLowerBound ? 'short' : 'long',
         style: fiatType ? 'currency' : 'decimal',
         currency: fiatType,
         minimumFractionDigits,
+        // Force enough fractional digits to truncate it properly without rounding off below
         maximumFractionDigits: 10,
-        ...options,
+        ...filteredOptions,
       })
 
       const parts = formatter.formatToParts(formatNumber)