This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
fix(swapper): osmosis multi-account swaps #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pastaghost
commented
Feb 23, 2023
•
pastaghost
commented
- fixes ATOM(account 0) -> OSMO(account 1) trades as reported by TShifty.
- note: there is probably a way to accomplish the same thing making better use of the type system than sticking an optional field onto the base trade types. I played around with this for a while, but ended up reverting to the naiive case for expediency. If you've got any suggestions, please let me know and I'll be happy to fix.
pastaghost
changed the title
5 tasks
|
This was never part of the osmosis bounty but ok |
gomesalexandre
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Not the biggest fan of receiveAccountNumber given we already have receiveAddress (should be one or the other, i.e we should be able to derive the receive address with the account number?), but won't nitpick this one, happy to merge in this state and maybe revisit later so we can unblock Osmo
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Feb 23, 2023
# [@shapeshiftoss/swapper-v17.3.1](https://github.com/shapeshift/lib/compare/@shapeshiftoss/swapper-v17.3.0...@shapeshiftoss/swapper-v17.3.1) (2023-02-23) ### Bug Fixes * **swapper:** osmosis multi-account swaps ([#1210](#1210)) ([6b5a7ab](6b5a7ab))
|
🎉 This PR is included in version @shapeshiftoss/swapper-v17.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.