Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mass and findBestNOccurrences functions #12

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Add mass and findBestNOccurrences functions #12

merged 1 commit into from
Jun 10, 2019

Conversation

jrecuerda
Copy link
Contributor

Make sure you have checked all steps below.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Benchmarks

  • My PR adds the following micro benchmarks OR does not need benchmarks for this extremely good reason:

Commits

  • My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

License

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.

@jrecuerda jrecuerda force-pushed the feature/findBestNOccurrences branch from 34e4252 to f9811b8 Compare June 10, 2019 07:22
otorreno
otorreno approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@otorreno otorreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrecuerda jrecuerda merged commit a2f2bb4 into master Jun 10, 2019
@jrecuerda jrecuerda deleted the feature/findBestNOccurrences branch June 10, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otorreno otorreno otorreno approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrecuerda @otorreno