Fix/import #45
Merged
Fix/import #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexfedoseev Please review. |
alex35mil
requested changes
Jul 31, 2017
src/utils/rewriteImports.js
Outdated
| // if import path starts with / resolve from project root or webpack.context | ||
| if ((/^\//).test(oldImportPath)) { | ||
| return path.join(rootContext, oldImportPath); | ||
| } |
There was a problem hiding this comment.
Is this a common pattern to write imports like this? It looks confusing.
src/loader.js
Outdated
| @@ -48,6 +48,8 @@ module.exports = function(source) { | |||
| ); | |||
| } | |||
|
|
|||
| const rootContext = webpack.options.context || process.cwd(); | |||
There was a problem hiding this comment.
There is webpackConfigContext on line 42.
This was referenced Jul 31, 2017
alex35mil
approved these changes
Aug 31, 2017
|
can we release this fix to npm? |
|
@kieran Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is