Helpful Message After Generator Install #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaronvb This looks awesome. Could you change "node-server-hot" to "express-server". I think that's a better name for the webpack dev server. @alexfedoseev @robwise Agree? Since there's no "cold", non-hot-reloading version of express, I think just |
|
|
aaronvb
force-pushed
the
generator_helpful_messages
branch
from
793bd31 to
cb1fa73
Compare
| @@ -10,7 +10,7 @@ | |||
| "scripts": { | |||
| "postinstall": "cd client && npm install", | |||
| "test": "rspec && (cd client && npm run lint)", | |||
| "node-server-hot": "echo 'visit http://localhost:4000' && cd client && npm start", | |||
| "express-server": "echo 'visit http://localhost:4000' && cd client && npm start", | |||
There was a problem hiding this comment.
Updated the npm run command node-server-hot to express-server.
|
The updated helpful message with
|
- Added a helpful message after base generator install. - Added a helpful message after react with redux generator install. - Added tests for both messages. - Change 'npm run node-server-hot' to 'npm run express-server'
aaronvb
force-pushed
the
generator_helpful_messages
branch
from
cb1fa73 to
89dd8b4
Compare
|
Thanks @aaronvb. Is this ready for merge and a dot release? |
|
@justin808 I just pushed an edit to the |
justin808
added a commit
that referenced
this pull request
Jan 19, 2016
Helpful Message After Generator Install
aaronvb
added a commit
to aaronvb/react_on_rails
that referenced
this pull request
Feb 5, 2016
- Change text node-server-hot to express-server. This was changed in shakacode#210 - Fix indentation.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rails generate react_on_rails:installrails generate react_on_rails:install -RResloves #184