Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test helper #1102

Merged
merged 9 commits into from
Jun 15, 2018
Merged

fix test helper #1102

merged 9 commits into from
Jun 15, 2018

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Jun 15, 2018

Review in #1093.

This change is Reviewable

@coveralls
Copy link

coveralls commented Jun 15, 2018

Coverage Status

Coverage remained the same at ?% when pulling ca2c1b3 on fix-test-helper into 1605b40 on master.

@justin808
Copy link
Member Author

@mapreal19 maybe skim this PR...just tiny changes beyond what you reviewed. Serious yak shave on the need to add this to the test!

after do
      ReactOnRails::Utils.instance_variable_set(:@server_bundle_path, nil)
    end

@justin808 justin808 merged commit 6c8d6a8 into master Jun 15, 2018
@justin808 justin808 deleted the fix-test-helper branch June 15, 2018 21:39
@mapreal19
Copy link
Contributor

:lgtm: 1 minor comment


Reviewed 10 of 10 files at r1.
Review status: all files reviewed, 1 unresolved discussion (waiting on @justin808)


lib/react_on_rails/webpacker_utils.rb, line 11 at r1 (raw file):

      # [2] (pry) ReactOnRails::WebpackerUtils: 0> Webpacker.manifest.lookup("app-bundle.js")
      # "/webpack/development/app-bundle-c1d2b6ab73dffa7d9c0e.js"
      # Next line will throw if the file or manifest does not exist

This info belongs to the lookup! method spec. Otherwise we would need to comment every time this method is being used.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants