Remove test case dependent on terraform
CLI
#248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Problem
Test case that checks that
cpflow terraform import
command is protected from shell injection depends on existence ofterraform
CLI tool - we shouldn't be dependent on itSolution
Removal of the test case
Note
We know that
Shell.cmd
callsOpen.capture2e/capture2
and passes an array as args - which is safe from shell injection. AndCommand::Terraform::Import#run_terraform_import
callsShell.cmd
the same way (string interpolation isn't used) - which means everything is safe