Skip to content

Commit

Permalink
Review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
zzaakiirr committed Nov 30, 2024
1 parent ec0c7a4 commit ee4a6df
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ _Please add entries here for your pull requests that have not yet been released.

- Fixed potential infinite loop that could occur for a command if one of the execution steps fails and gets stuck. [PR 217](https://github.com/shakacode/control-plane-flow/pull/217) by [Zakir Dzhamaliddinov](https://github.com/zzaakiirr).

- Fixed issue where GVC cannot be deleted because one of the workloads has volumeset in-use. [PR 245](https://github.com/shakacode/control-plane-flow/pull/245) by [Zakir Dzhamaliddinov](https://github.com/zzaakiirr).
- Fixed issue where app cannot be deleted because one of the workloads has a volumeset in-use. [PR 245](https://github.com/shakacode/control-plane-flow/pull/245) by [Zakir Dzhamaliddinov](https://github.com/zzaakiirr).

## [4.0.0] - 2024-08-21

Expand Down
2 changes: 1 addition & 1 deletion lib/command/delete.rb
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def delete_workload(workload)
def delete_volumesets
@volumesets.each do |volumeset|
step("Deleting volumeset '#{volumeset['name']}' from app '#{config.app}'") do
# If the volumeset is attached to a workloads, we need to delete the workloads first
# If the volumeset is attached to workloads, we need to delete the workloads first
workloads = volumeset.dig("status", "workloadLinks")&.map { |workload_link| workload_link.split("/").last }
workloads&.each { |workload| cp.delete_workload(workload) }

Expand Down

0 comments on commit ee4a6df

Please sign in to comment.